Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Udpate SDK #157

Merged
merged 8 commits into from
Jul 31, 2024
Merged

Udpate SDK #157

merged 8 commits into from
Jul 31, 2024

Conversation

lovromazgon
Copy link
Member

@lovromazgon lovromazgon commented Jul 29, 2024 •
edited
Loading

Description

Updates the SDK to use the latest version. It points to a commit in a PR, so we will update it again before releasing, this now simply unblocks some work in other repos.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lovromazgon lovromazgon marked this pull request as ready for review July 30, 2024 17:50
@lovromazgon lovromazgon requested a review from a team as a code owner July 30, 2024 17:50
hariso
hariso approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@hariso hariso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥇

hariso
hariso reviewed Jul 31, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@lovromazgon lovromazgon enabled auto-merge (squash) July 31, 2024 12:33
@lovromazgon lovromazgon disabled auto-merge July 31, 2024 12:34
@lovromazgon lovromazgon enabled auto-merge (squash) July 31, 2024 13:19
@lovromazgon lovromazgon merged commit 607d878 into main Jul 31, 2024
4 checks passed
@lovromazgon lovromazgon deleted the lovro/update-sdk branch July 31, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulb raulb raulb left review comments

@hariso hariso hariso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lovromazgon @raulb @hariso